-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure repository #11744
Restructure repository #11744
Conversation
RussKie
commented
May 19, 2024
- Rename Setup/ to setup/
- Rename Bin/ into assets/ and move under setup/
- Rename Externals/ to externals/
- Move app projects into src/
- Move test projects into tests/
- Move scripts/ to eng/
- Move TranslationApp/ into setup/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I am not fond of moving files around, it breaks patches and history.
Can't disagree, though renames/moves should work more or less. The root of the repo is very messy, which is confusing, and it could be a barrier for prospective contributors. This has been bothering me for many years, and this is my Nth attempt, which I finally pushed in. |
I will approve if you rebase #10906 and consider taking it out of draft - it works fine as is (also mstv workaround) |
Sure thing. |
Yes, we can't say that Git (or GitExtensions) is handling move and rename perfectly. Crossing the fingers very hard that Blame is not "broken" and that WIP will rebase without problem....
Why not.
💯 "Bin" was always something to be careful when cleaning manually .net "bin" folders.
👍 (that's how I prefer to have it)
I absolutely don't have a clue of what "eng" could means: so either I will learn a new word/meaning or I'm not very convinced....
Why not. |
That's my plan to move that markdown and the gif to the wiki. These have little use or relevance in the repo itself.
"eng" is short for "engineering". That's a convention in the dotnet/* repos and many other MS internal repos. So for me that's kind of natural... Do you have any other preference? |
TIL. Ok for me (even if it makes me think more about "eng(lish)" than "eng(ineering)". No better idea. And let's not reinvent a convention (which, as a consequence, won't be a convention 🤔 )
I will be more than happy if it is done in this PR... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible, have not run
I do not see at the first and second glance why the AppVeyor build timed out > 4 minutes after "build success".
Crossing the fingers very hard that Blame is not "broken"
It worked well this time except for a few MSVS project files - if squashed into a single commit.
The "sorting" feature was a great help for the review:
This is ready. Unless there are objections I'm planning to merge it tomorrow. |
Done. https://github.com/gitextensions/gitextensions/wiki/How-to-visualize-Git-repository's-history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Git is able to automatically resolve the MC when rebasing
They are some cases where Git is not good:
|
* Rename Setup/ to setup/ * Rename Bin/ into assets/ and move under setup/ * Rename Externals/ to externals/ * Move app projects into src/ * Move test projects into tests/ * Move scripts/ to eng/ * Move TranslationApp/ into setup/
We know - unfortunately.
the MC (of this PR) |
I wonder if this PR does not break the
|
Forget my comment. Found the issue, 1 min later....... 🙄 |